fix broken exit code checks in rpm-ostree install #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is correctly failing on the 5.4 PR with that so it seems to work properly now: |
We can check the rpm-ostree image URL always as this is set by the build process. What we cannot check is the real podman version in the image right now as this depens on the moving copr target. Signed-off-by: Paul Holzinger <[email protected]>
The install commands could have failed without failing the build due to us not checking the exit codes. Signed-off-by: Paul Holzinger <[email protected]>
From the docs[1]: In a container build, it’s a current best practice to invoke this at the end of each RUN instruction. Thus we should add it here, I did not add it for other RUN's as those are simple file operations that should not effect other things really. [1] https://coreos.github.io/rpm-ostree/container/#using-ostree-container-commit Signed-off-by: Paul Holzinger <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits, fixes the missing exit code checks in the rpm-ostree install of podman that caused #75 to go unnoticed